diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-09-18 16:31:33 -0700 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2015-09-23 14:08:35 +0200 |
| commit | 79b568b9d0c7c5d81932f4486d50b38efdd6da6d (patch) | |
| tree | 4b32fb032a341706cde7f365485837dee1c78c34 /drivers/hid | |
| parent | HID: sensor-hub: Fixup for Lenovo ThinkPad Helix 2 sensor hub report (diff) | |
| download | linux-dev-79b568b9d0c7c5d81932f4486d50b38efdd6da6d.tar.xz linux-dev-79b568b9d0c7c5d81932f4486d50b38efdd6da6d.zip | |
HID: core: Avoid uninitialized buffer access
hid_connect adds various strings to the buffer but they're all
conditional. You can find circumstances where nothing would be written
to it but the kernel will still print the supposedly empty buffer with
printk. This leads to corruption on the console/in the logs.
Ensure buf is initialized to an empty string.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
[dvhart: Initialize string to "" rather than assign buf[0] = NULL;]
Cc: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index bcd914a63af2..4130685fca7c 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1611,7 +1611,7 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask) "Multi-Axis Controller" }; const char *type, *bus; - char buf[64]; + char buf[64] = ""; unsigned int i; int len; int ret; |