diff options
| author |   José Expósito <jose.exposito89@gmail.com> | 2022-01-05 18:29:15 +0100 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2022-01-06 15:39:43 +0100 |
| commit | aa320fdbbbb482c19100f51461bd0069753ce3d7 (patch) | |
| tree | f4d8ce06bbd7ec779d424920488430efeadb21c1 /drivers/hid | |
| parent | HID: hid-uclogic-params: Invalid parameter check in uclogic_params_huion_init (diff) | |
| download | linux-dev-aa320fdbbbb482c19100f51461bd0069753ce3d7.tar.xz linux-dev-aa320fdbbbb482c19100f51461bd0069753ce3d7.zip | |
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_buttonpad
The function performs a check on the hdev input parameters, however, it
is used before the check.
Initialize the udev variable after the sanity check to avoid a
possible NULL pointer dereference.
Fixes: 9614219e9310e ("HID: uclogic: Extract tablet parameter discovery into a module")
Addresses-Coverity-ID: 1443763 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-uclogic-params.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c index 4136837e4d15..3e70f969fb84 100644 --- a/drivers/hid/hid-uclogic-params.c +++ b/drivers/hid/hid-uclogic-params.c @@ -452,7 +452,7 @@ static int uclogic_params_frame_init_v1_buttonpad( { int rc; bool found = false; - struct usb_device *usb_dev = hid_to_usb_dev(hdev); + struct usb_device *usb_dev; char *str_buf = NULL; const size_t str_len = 16; @@ -462,6 +462,8 @@ static int uclogic_params_frame_init_v1_buttonpad( goto cleanup; } + usb_dev = hid_to_usb_dev(hdev); + /* * Enable generic button mode */ |