diff options
| author |   Evgeny Novikov <novikov@ispras.ru> | 2021-07-30 19:51:08 +0300 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2021-08-20 14:24:56 +0200 |
| commit | d0f1d5ae23803bd82647a337fa508fa8615defc5 (patch) | |
| tree | df83074bb692c02daec60ef74069b98d64f6bb13 /drivers/hid | |
| parent | Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid (diff) | |
| download | linux-dev-d0f1d5ae23803bd82647a337fa508fa8615defc5.tar.xz linux-dev-d0f1d5ae23803bd82647a337fa508fa8615defc5.zip | |
HID: thrustmaster: Fix memory leaks in probe
When thrustmaster_probe() handles errors of usb_submit_urb() it does not
free allocated resources and fails. The patch fixes that.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-thrustmaster.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index cdc7d82ae9ed..e94d3409fd10 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -336,11 +336,14 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i ); ret = usb_submit_urb(tm_wheel->urb, GFP_ATOMIC); - if (ret) + if (ret) { hid_err(hdev, "Error %d while submitting the URB. I am unable to initialize this wheel...\n", ret); + goto error6; + } return ret; +error6: kfree(tm_wheel->change_request); error5: kfree(tm_wheel->response); error4: kfree(tm_wheel->model_request); error3: usb_free_urb(tm_wheel->urb); |