diff options
| author |   Vitaly Kuznetsov <vkuznets@redhat.com> | 2016-06-03 17:09:24 -0700 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-31 13:05:41 +0200 |
| commit | 7cc80c98070ccc7940fc28811c92cca0a681015d (patch) | |
| tree | 1e94c74793a76e6ef001dc87bd87d46ffa6cdf83 /drivers/hv/channel.c | |
| parent | Drivers: hv: get rid of redundant messagecount in create_gpadl_header() (diff) | |
| download | linux-dev-7cc80c98070ccc7940fc28811c92cca0a681015d.tar.xz linux-dev-7cc80c98070ccc7940fc28811c92cca0a681015d.zip | |
Drivers: hv: don't leak memory in vmbus_establish_gpadl()
In some cases create_gpadl_header() allocates submessages but we never
free them.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hv/channel.c')
| -rw-r--r-- | drivers/hv/channel.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 2b109e8a8c97..a68830c848e4 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -388,7 +388,7 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, struct vmbus_channel_gpadl_header *gpadlmsg; struct vmbus_channel_gpadl_body *gpadl_body; struct vmbus_channel_msginfo *msginfo = NULL; - struct vmbus_channel_msginfo *submsginfo; + struct vmbus_channel_msginfo *submsginfo, *tmp; struct list_head *curr; u32 next_gpadl_handle; unsigned long flags; @@ -445,6 +445,10 @@ cleanup: spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_del(&msginfo->msglistentry); spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); + list_for_each_entry_safe(submsginfo, tmp, &msginfo->submsglist, + msglistentry) { + kfree(submsginfo); + } kfree(msginfo); return ret; |