diff options
| author |   Tianyu Lan <Tianyu.Lan@microsoft.com> | 2020-04-06 08:53:27 -0700 |
|---|---|---|
| committer |   Wei Liu <wei.liu@kernel.org> | 2020-04-10 15:29:00 +0100 |
| commit | 7f11a2cc10a4ae3a70e2c73361f4a9a33503539b (patch) | |
| tree | 5c799e18df8d2d4c9a14c65e5e1704231aefaca8 /drivers/hv | |
| parent | x86/Hyper-V: Unload vmbus channel in hv panic callback (diff) | |
| download | linux-dev-7f11a2cc10a4ae3a70e2c73361f4a9a33503539b.tar.xz linux-dev-7f11a2cc10a4ae3a70e2c73361f4a9a33503539b.zip | |
x86/Hyper-V: Free hv_panic_page when fail to register kmsg dump
If kmsg_dump_register() fails, hv_panic_page will not be used
anywhere. So free and reset it.
Fixes: 81b18bce48af ("Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic")
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
Link: https://lore.kernel.org/r/20200406155331.2105-3-Tianyu.Lan@microsoft.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Diffstat (limited to 'drivers/hv')
| -rw-r--r-- | drivers/hv/vmbus_drv.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 6478240d11ab..00a511f15926 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -1385,9 +1385,13 @@ static int vmbus_bus_init(void) hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page(); if (hv_panic_page) { ret = kmsg_dump_register(&hv_kmsg_dumper); - if (ret) + if (ret) { pr_err("Hyper-V: kmsg dump register " "error 0x%x\n", ret); + hv_free_hyperv_page( + (unsigned long)hv_panic_page); + hv_panic_page = NULL; + } } else pr_err("Hyper-V: panic message page memory " "allocation failed"); @@ -1416,7 +1420,6 @@ err_alloc: hv_remove_vmbus_irq(); bus_unregister(&hv_bus); - hv_free_hyperv_page((unsigned long)hv_panic_page); unregister_sysctl_table(hv_ctl_table_hdr); hv_ctl_table_hdr = NULL; return ret; |