diff options
| author |   Liang He <windhl@126.com> | 2022-09-16 23:47:08 +0800 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2022-09-19 06:16:39 -0700 |
| commit | 7f62cf781e6567d59c8935dc8c6068ce2bb904b7 (patch) | |
| tree | d3dc551c0c5af2e61f5b5a49c399553c81118988 /drivers/hwmon/gsc-hwmon.c | |
| parent | hwmon: (aquacomputer_d5next) Fix Quadro fan speed offsets (diff) | |
| download | linux-dev-7f62cf781e6567d59c8935dc8c6068ce2bb904b7.tar.xz linux-dev-7f62cf781e6567d59c8935dc8c6068ce2bb904b7.zip | |
hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API
In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
the of_find_compatible_node() which will automatically call
of_node_put() for the 'from' argument.
Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
Signed-off-by: Liang He <windhl@126.com>
Co-developed-by: Mengda Chen <chenmengda2009@163.com>
Signed-off-by: Mengda Chen <chenmengda2009@163.com>
Link: https://lore.kernel.org/r/20220916154708.3084515-1-chenmengda2009@163.com
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/gsc-hwmon.c')
| -rw-r--r-- | drivers/hwmon/gsc-hwmon.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hwmon/gsc-hwmon.c b/drivers/hwmon/gsc-hwmon.c index d64be48f1ef6..b60ec95b5edb 100644 --- a/drivers/hwmon/gsc-hwmon.c +++ b/drivers/hwmon/gsc-hwmon.c @@ -267,6 +267,7 @@ gsc_hwmon_get_devtree_pdata(struct device *dev) pdata->nchannels = nchannels; /* fan controller base address */ + of_node_get(dev->parent->of_node); fan = of_find_compatible_node(dev->parent->of_node, NULL, "gw,gsc-fan"); if (fan && of_property_read_u32(fan, "reg", &pdata->fan_base)) { of_node_put(fan); |