diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2016-12-22 13:04:46 +0100 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2017-01-02 10:19:45 -0800 |
| commit | 3eb52cfdf5d3b04ffb6cfcd6a7506f5b2b27b0bf (patch) | |
| tree | 1fc55a395e7da8622978229abaa61edf5f3680ad /drivers/hwmon/i5500_temp.c | |
| parent | hwmon: (core) use permission-specific DEVICE_ATTR variants (diff) | |
| download | linux-dev-3eb52cfdf5d3b04ffb6cfcd6a7506f5b2b27b0bf.tar.xz linux-dev-3eb52cfdf5d3b04ffb6cfcd6a7506f5b2b27b0bf.zip | |
hwmon: (i5500_temp) use permission-specific DEVICE_ATTR variants
Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.
The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/i5500_temp.c')
| -rw-r--r-- | drivers/hwmon/i5500_temp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hwmon/i5500_temp.c b/drivers/hwmon/i5500_temp.c index 3e3ccbf18b4e..400e0675a90b 100644 --- a/drivers/hwmon/i5500_temp.c +++ b/drivers/hwmon/i5500_temp.c @@ -43,8 +43,8 @@ */ /* Sensor resolution : 0.5 degree C */ -static ssize_t show_temp(struct device *dev, - struct device_attribute *devattr, char *buf) +static ssize_t temp1_input_show(struct device *dev, + struct device_attribute *devattr, char *buf) { struct pci_dev *pdev = to_pci_dev(dev->parent); long temp; @@ -83,7 +83,7 @@ static ssize_t show_alarm(struct device *dev, return sprintf(buf, "%u\n", (unsigned int)ctsts & (1 << nr)); } -static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); +static DEVICE_ATTR_RO(temp1_input); static SENSOR_DEVICE_ATTR(temp1_crit, S_IRUGO, show_thresh, NULL, 0xE2); static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IRUGO, show_thresh, NULL, 0xEC); static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO, show_thresh, NULL, 0xEE); |