diff options
| author |   Guenter Roeck <linux@roeck-us.net> | 2016-08-09 22:09:19 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2016-08-11 18:35:47 -0700 |
| commit | aa8b187eeab5e6757e959b81889ddbfda7d02ad1 (patch) | |
| tree | c4a094a0388e5823373c40cf78b582b3fbd5ef7f /drivers/hwmon/it87.c | |
| parent | Linux 4.8-rc1 (diff) | |
| download | linux-dev-aa8b187eeab5e6757e959b81889ddbfda7d02ad1.tar.xz linux-dev-aa8b187eeab5e6757e959b81889ddbfda7d02ad1.zip | |
hwmon: (it87) Features mask must be 32 bit wide
Coverity reports:
result_independent_of_operands: data->features & (65536UL /* 1UL << 16 */)
is always 0 regardless of the values of its operands. This occurs as the
logical operand of if.
data->features needs to be 32 bit wide since there are more than 16 features.
Fixes: cc18da79d9b7 ("hwmon: (it87) Support up to 6 temperature sensors ... ");
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/it87.c')
| -rw-r--r-- | drivers/hwmon/it87.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 730d84028260..d0203a115eff 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -491,7 +491,7 @@ struct it87_sio_data { struct it87_data { const struct attribute_group *groups[7]; enum chips type; - u16 features; + u32 features; u8 peci_mask; u8 old_peci_mask; |