diff options
| author |   Guenter Roeck <linux@roeck-us.net> | 2016-12-04 18:16:02 -0800 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2016-12-12 11:33:42 -0800 |
| commit | 12fa55ccc49df52617d7454ba448c1876e189bac (patch) | |
| tree | 5eceb0df03440c77bb1a28a6aeaf26381644fc8a /drivers/hwmon/lm87.c | |
| parent | hwmon: (nct7802) Fix overflows seen when writing into limit attributes (diff) | |
| download | linux-dev-12fa55ccc49df52617d7454ba448c1876e189bac.tar.xz linux-dev-12fa55ccc49df52617d7454ba448c1876e189bac.zip | |
hwmon: (lm87) Fix overflow seen when writing voltage limit attributes
Writes into voltage limit attributes can overflow due to an unbound
multiplication.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/lm87.c')
| -rw-r--r-- | drivers/hwmon/lm87.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c index 81cb898245a1..13cca3606e06 100644 --- a/drivers/hwmon/lm87.c +++ b/drivers/hwmon/lm87.c @@ -121,7 +121,7 @@ static u8 LM87_REG_TEMP_LOW[3] = { 0x3A, 0x38, 0x2C }; #define IN_FROM_REG(reg, scale) (((reg) * (scale) + 96) / 192) #define IN_TO_REG(val, scale) ((val) <= 0 ? 0 : \ - (val) * 192 >= (scale) * 255 ? 255 : \ + (val) >= (scale) * 255 / 192 ? 255 : \ ((val) * 192 + (scale) / 2) / (scale)) #define TEMP_FROM_REG(reg) ((reg) * 1000) |