diff options
| author |   Guenter Roeck <linux@roeck-us.net> | 2018-12-10 14:02:22 -0800 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2019-02-18 14:23:29 -0800 |
| commit | 5abcbc7beecaa023a24dc79dd1534463fff727ed (patch) | |
| tree | 3f96b0144fc16e55ad332ce5399ee6746435728b /drivers/hwmon/tc74.c | |
| parent | hwmon: (tc654) Use permission specific SENSOR[_DEVICE]_ATTR variants (diff) | |
| download | linux-dev-5abcbc7beecaa023a24dc79dd1534463fff727ed.tar.xz linux-dev-5abcbc7beecaa023a24dc79dd1534463fff727ed.zip | |
hwmon: (tc74) Use permission specific SENSOR[_DEVICE]_ATTR variants
Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readability, and to reduce the chance of inconsistencies.
Also replace any remaining S_<PERMS> in the driver with octal values.
The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/.
This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/tc74.c')
| -rw-r--r-- | drivers/hwmon/tc74.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwmon/tc74.c b/drivers/hwmon/tc74.c index d95165158800..fa306bb681bb 100644 --- a/drivers/hwmon/tc74.c +++ b/drivers/hwmon/tc74.c @@ -86,7 +86,7 @@ ret_unlock: return ret; } -static ssize_t show_temp_input(struct device *dev, +static ssize_t temp_input_show(struct device *dev, struct device_attribute *attr, char *buf) { struct tc74_data *data = dev_get_drvdata(dev); @@ -98,7 +98,7 @@ static ssize_t show_temp_input(struct device *dev, return sprintf(buf, "%d\n", data->temp_input * 1000); } -static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp_input, NULL, 0); +static SENSOR_DEVICE_ATTR_RO(temp1_input, temp_input, 0); static struct attribute *tc74_attrs[] = { &sensor_dev_attr_temp1_input.dev_attr.attr, |