diff options
| author |   Guenter Roeck <linux@roeck-us.net> | 2019-04-18 12:58:19 -0700 |
|---|---|---|
| committer |   Eduardo Valentin <edubezval@gmail.com> | 2019-05-14 07:00:46 -0700 |
| commit | 0b2a785db8797db08181f71395a412c8eedbc614 (patch) | |
| tree | af211149d17dcd08ac88fd657226146c1c92928c /drivers/hwmon | |
| parent | hwmon: (mlxreg-fan) Use devm_thermal_of_cooling_device_register (diff) | |
| download | linux-dev-0b2a785db8797db08181f71395a412c8eedbc614.tar.xz linux-dev-0b2a785db8797db08181f71395a412c8eedbc614.zip | |
hwmon: (npcm750-pwm-fan) Use devm_thermal_of_cooling_device_register
Use devm_thermal_of_cooling_device_register() to register the cooling
device. As a side effect, this fixes a driver bug:
thermal_cooling_device_unregister() was not called on device removal.
Fixes: f1fd4a4db777 ("hwmon: Add NPCM7xx PWM and Fan driver")
Cc: Tomer Maimon <tmaimon77@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/npcm750-pwm-fan.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/hwmon/npcm750-pwm-fan.c b/drivers/hwmon/npcm750-pwm-fan.c index b3b907bdfb63..f24cc00caba9 100644 --- a/drivers/hwmon/npcm750-pwm-fan.c +++ b/drivers/hwmon/npcm750-pwm-fan.c @@ -864,10 +864,8 @@ static int npcm7xx_create_pwm_cooling(struct device *dev, snprintf(cdev->name, THERMAL_NAME_LENGTH, "%pOFn%d", child, pwm_port); - cdev->tcdev = thermal_of_cooling_device_register(child, - cdev->name, - cdev, - &npcm7xx_pwm_cool_ops); + cdev->tcdev = devm_thermal_of_cooling_device_register(dev, child, + cdev->name, cdev, &npcm7xx_pwm_cool_ops); if (IS_ERR(cdev->tcdev)) return PTR_ERR(cdev->tcdev); |