diff options
| author |   Armin Wolf <W_Armin@gmx.de> | 2022-04-26 23:31:54 +0200 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2022-05-20 10:57:05 -0700 |
| commit | 981c5f3c744bbe2e6420a8a834d52c7ed2a75b7f (patch) | |
| tree | 56c3eac636bc38a7580af3cfe16a01d30884fbed /drivers/hwmon | |
| parent | hwmon: (dell-smm) Cleanup init code (diff) | |
| download | linux-dev-981c5f3c744bbe2e6420a8a834d52c7ed2a75b7f.tar.xz linux-dev-981c5f3c744bbe2e6420a8a834d52c7ed2a75b7f.zip | |
hwmon: (dell-smm) Warn if SMM call took a very long time to execute
If a particular SMM call takes a very long time to execute,
the user might experience audio problems. Print a warning
if a particular SMM call took over 0.250 seconds to execute,
so the user can check whether or not possible audio problems
are caused by this driver.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20220426213154.724708-4-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/dell-smm-hwmon.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index f13902414615..071aa6f4e109 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -49,6 +49,9 @@ #define I8K_SMM_GET_DELL_SIG1 0xfea3 #define I8K_SMM_GET_DELL_SIG2 0xffa3 +/* in usecs */ +#define DELL_SMM_MAX_DURATION 250000 + #define I8K_FAN_MULT 30 #define I8K_FAN_RPM_THRESHOLD 1000 #define I8K_MAX_TEMP 127 @@ -239,6 +242,9 @@ static int i8k_smm_func(void *par) pr_debug("smm(0x%.4x 0x%.4x) = 0x%.4x (took %7lld usecs)\n", eax, ebx, (rc ? 0xffff : regs->eax & 0xffff), duration); + if (duration > DELL_SMM_MAX_DURATION) + pr_warn_once("SMM call took %lld usecs!\n", duration); + return rc; } |