aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorColin Ian King <colin.i.king@gmail.com>2021-12-04 23:31:55 +0000
committerGuenter Roeck <linux@roeck-us.net>2021-12-26 15:02:06 -0800
commitd75553790b9f44f9a6023a51ca5283ef4688f339 (patch)
tree4b806d1b3a7238eff07373ba4167d5cb9981bd4d /drivers/hwmon
parenthwmon: (asus_wmi_sensors) fix an array overflow (diff)
downloadlinux-dev-d75553790b9f44f9a6023a51ca5283ef4688f339.tar.xz
linux-dev-d75553790b9f44f9a6023a51ca5283ef4688f339.zip
hwmon: (adm1031) Remove redundant assignment to variable range
Variable range is being initialized with a value that is never read, it is being re-assigned in the next statement. The assignment is redundant, remove it and initialize range using the second assigned value. Clean up the formatting too by adding missing spaces. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20211204233155.55454-1-colin.i.king@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/adm1031.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
index 257ec53ae723..ac841fa3a369 100644
--- a/drivers/hwmon/adm1031.c
+++ b/drivers/hwmon/adm1031.c
@@ -242,9 +242,8 @@ static int FAN_TO_REG(int reg, int div)
static int AUTO_TEMP_MAX_TO_REG(int val, int reg, int pwm)
{
int ret;
- int range = val - AUTO_TEMP_MIN_FROM_REG(reg);
+ int range = ((val - AUTO_TEMP_MIN_FROM_REG(reg)) * 10) / (16 - pwm);
- range = ((val - AUTO_TEMP_MIN_FROM_REG(reg))*10)/(16 - pwm);
ret = ((reg & 0xf8) |
(range < 10000 ? 0 :
range < 20000 ? 1 :