diff options
| author |   Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-19 16:00:02 -0500 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2019-08-31 08:04:57 -0700 |
| commit | e027a2dea5fdde05740a98f571fc2903060559ce (patch) | |
| tree | edc75af2c0a56bd09f9d9773009457e7ab2fdcf3 /drivers/hwmon | |
| parent | hwmon: (lm75) Fix write operations for negative temperatures (diff) | |
| download | linux-dev-e027a2dea5fdde05740a98f571fc2903060559ce.tar.xz linux-dev-e027a2dea5fdde05740a98f571fc2903060559ce.zip | |
hwmon (coretemp) Fix a memory leak bug
In coretemp_init(), 'zone_devices' is allocated through kcalloc().
However, it is not deallocated in the following execution if
platform_driver_register() fails, leading to a memory leak. To fix this
issue, introduce the 'outzone' label to free 'zone_devices' before
returning the error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Link: https://lore.kernel.org/r/1566248402-6538-1-git-send-email-wenwen@cs.uga.edu
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/coretemp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index fe6618e49dc4..d855c78fb8be 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -736,7 +736,7 @@ static int __init coretemp_init(void) err = platform_driver_register(&coretemp_driver); if (err) - return err; + goto outzone; err = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "hwmon/coretemp:online", coretemp_cpu_online, coretemp_cpu_offline); @@ -747,6 +747,7 @@ static int __init coretemp_init(void) outdrv: platform_driver_unregister(&coretemp_driver); +outzone: kfree(zone_devices); return err; } |