diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2018-09-05 10:46:27 +0300 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2018-09-05 14:47:50 -0700 |
| commit | e3f3d7ab00cd459d0f7a839758a4542f4d4b8ac8 (patch) | |
| tree | b6bc22f3467df9d9ca24e84a59cc2df934b898fe /drivers/hwmon | |
| parent | Linux 4.19-rc2 (diff) | |
| download | linux-dev-e3f3d7ab00cd459d0f7a839758a4542f4d4b8ac8.tar.xz linux-dev-e3f3d7ab00cd459d0f7a839758a4542f4d4b8ac8.zip | |
hwmon: (nct6775) Set weight source to zero correctly
This is dead code because j can never be 1 at this point. We had
intended to just test if the bit was clear.
Fixes: bbd8decd4123 ("hwmon: (nct6775) Add support for weighted fan control")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/nct6775.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index 944f5b63aecd..139781ae830b 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon/nct6775.c @@ -1558,7 +1558,7 @@ static void nct6775_update_pwm(struct device *dev) reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]); data->pwm_weight_temp_sel[i] = reg & 0x1f; /* If weight is disabled, report weight source as 0 */ - if (j == 1 && !(reg & 0x80)) + if (!(reg & 0x80)) data->pwm_weight_temp_sel[i] = 0; /* Weight temp data */ |