aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/hwtracing/coresight/coresight-cti-platform.c
diff options
context:
space:
mode:
authorCalvin Johnson <calvin.johnson@oss.nxp.com>2020-05-07 11:05:47 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-05-15 16:32:20 +0200
commit0bedaa2d6a05b8a736339368b7f33aeeef128cfa (patch)
treea9daf85cc43257bf3cb96132d6ebdd7e2c3db197 /drivers/hwtracing/coresight/coresight-cti-platform.c
parentmei: release me_cl object reference (diff)
downloadlinux-dev-0bedaa2d6a05b8a736339368b7f33aeeef128cfa.tar.xz
linux-dev-0bedaa2d6a05b8a736339368b7f33aeeef128cfa.zip
coresight: cti: remove incorrect NULL return check
fwnode_find_reference() doesn't return NULL and hence that check should be avoided. Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Link: https://lore.kernel.org/r/20200507053547.13707-1-calvin.johnson@oss.nxp.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwtracing/coresight/coresight-cti-platform.c')
-rw-r--r--drivers/hwtracing/coresight/coresight-cti-platform.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c
index b44d83142b62..2fdaeec80ee5 100644
--- a/drivers/hwtracing/coresight/coresight-cti-platform.c
+++ b/drivers/hwtracing/coresight/coresight-cti-platform.c
@@ -120,7 +120,7 @@ static int cti_plat_create_v8_etm_connection(struct device *dev,
/* Can optionally have an etm node - return if not */
cs_fwnode = fwnode_find_reference(root_fwnode, CTI_DT_CSDEV_ASSOC, 0);
- if (IS_ERR_OR_NULL(cs_fwnode))
+ if (IS_ERR(cs_fwnode))
return 0;
/* allocate memory */
@@ -393,7 +393,7 @@ static int cti_plat_create_connection(struct device *dev,
/* associated device ? */
cs_fwnode = fwnode_find_reference(fwnode,
CTI_DT_CSDEV_ASSOC, 0);
- if (!IS_ERR_OR_NULL(cs_fwnode)) {
+ if (!IS_ERR(cs_fwnode)) {
assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode,
&csdev);
fwnode_handle_put(cs_fwnode);