diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-06-20 16:12:37 -0600 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-03 21:15:33 +0200 |
| commit | 0530ef6b41e80c5cc979e0e50682302161edb6b7 (patch) | |
| tree | 9d8801962fccbaf1844db9a86cb0f70d0d3efee2 /drivers/hwtracing/coresight/coresight-funnel.c | |
| parent | coresight: etb10: Do not call smp_processor_id from preemptible (diff) | |
| download | linux-dev-0530ef6b41e80c5cc979e0e50682302161edb6b7.tar.xz linux-dev-0530ef6b41e80c5cc979e0e50682302161edb6b7.zip | |
coresight: Potential uninitialized variable in probe()
The "drvdata->atclk" clock is optional, but if it gets set to an error
pointer then we're accidentally return an uninitialized variable instead
of success.
Fixes: 78e6427b4e7b ("coresight: funnel: Support static funnel")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20190620221237.3536-6-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwtracing/coresight/coresight-funnel.c')
| -rw-r--r-- | drivers/hwtracing/coresight/coresight-funnel.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index 5867fcb4503b..fa97cb9ab4f9 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -244,6 +244,7 @@ static int funnel_probe(struct device *dev, struct resource *res) } pm_runtime_put(dev); + ret = 0; out_disable_clk: if (ret && !IS_ERR_OR_NULL(drvdata->atclk)) |