diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2017-11-22 17:52:24 +0000 |
|---|---|---|
| committer |   Wolfram Sang <wsa@the-dreams.de> | 2017-11-27 19:14:29 +0100 |
| commit | 66a7c84d677e8e4a5a2ef4afdb9bd52e1399a866 (patch) | |
| tree | 2d15545273cc43033c0faeb353a09ffd30a7c7d5 /drivers/i2c/i2c-boardinfo.c | |
| parent | i2c: i801: Fix Failed to allocate irq -2147483648 error (diff) | |
| download | linux-dev-66a7c84d677e8e4a5a2ef4afdb9bd52e1399a866.tar.xz linux-dev-66a7c84d677e8e4a5a2ef4afdb9bd52e1399a866.zip | |
i2c: i2c-boardinfo: fix memory leaks on devinfo
Currently when an error occurs devinfo is still allocated but is
unused when the error exit paths break out of the for-loop. Fix
this by kfree'ing devinfo to avoid the leak.
Detected by CoverityScan, CID#1416590 ("Resource Leak")
Fixes: 4124c4eba402 ("i2c: allow attaching IRQ resources to i2c_board_info")
Fixes: 0daaf99d8424 ("i2c: copy device properties when using i2c_register_board_info()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c/i2c-boardinfo.c')
| -rw-r--r-- | drivers/i2c/i2c-boardinfo.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-boardinfo.c b/drivers/i2c/i2c-boardinfo.c index 31186ead5a40..509a6007cdf6 100644 --- a/drivers/i2c/i2c-boardinfo.c +++ b/drivers/i2c/i2c-boardinfo.c @@ -86,6 +86,7 @@ int i2c_register_board_info(int busnum, struct i2c_board_info const *info, unsig property_entries_dup(info->properties); if (IS_ERR(devinfo->board_info.properties)) { status = PTR_ERR(devinfo->board_info.properties); + kfree(devinfo); break; } } @@ -98,6 +99,7 @@ int i2c_register_board_info(int busnum, struct i2c_board_info const *info, unsig GFP_KERNEL); if (!devinfo->board_info.resources) { status = -ENOMEM; + kfree(devinfo); break; } } |