diff options
| author |   Jean Delvare <khali@linux-fr.org> | 2008-07-14 22:38:36 +0200 |
|---|---|---|
| committer |   Jean Delvare <khali@mahadeva.delvare> | 2008-07-14 22:38:36 +0200 |
| commit | 8508159e2f3b82bf109f0ec77bcbd8ff3f3a7e17 (patch) | |
| tree | 34df907dc530ce8f2d9ac10b24454f85eaf4a4da /drivers/i2c/i2c-core.c | |
| parent | i2c: Clean up old chip drivers (diff) | |
| download | linux-dev-8508159e2f3b82bf109f0ec77bcbd8ff3f3a7e17.tar.xz linux-dev-8508159e2f3b82bf109f0ec77bcbd8ff3f3a7e17.zip | |
i2c: Call client_unregister for new-style devices too
We call adapter->client_register for both legacy and new-style i2c
devices, however we only call adapter->client_unregister for legacy
drivers. This doesn't make much sense. Usually, drivers will undo
in client_unregister what they did in client_register, so we should
call neither or both for every given i2c device.
In order to ease the transition from legacy to new-style devices, it
seems preferable to actually call both.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: David Brownell <david-b@pacbell.net>
Diffstat (limited to 'drivers/i2c/i2c-core.c')
| -rw-r--r-- | drivers/i2c/i2c-core.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index e45bb2838f42..5e249d758828 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -300,6 +300,14 @@ void i2c_unregister_device(struct i2c_client *client) return; } + if (adapter->client_unregister) { + if (adapter->client_unregister(client)) { + dev_warn(&client->dev, + "client_unregister [%s] failed\n", + client->name); + } + } + mutex_lock(&adapter->clist_lock); list_del(&client->list); mutex_unlock(&adapter->clist_lock); |