diff options
| author |   Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2018-04-03 21:11:50 +0200 |
|---|---|---|
| committer |   Wolfram Sang <wsa@the-dreams.de> | 2018-04-11 23:33:46 +0200 |
| commit | 1eace8344c02c625ee99cc3ffa50187ded2c87b5 (patch) | |
| tree | b8aabc3206f9064036a78593069ddf824f095aa2 /drivers/i2c | |
| parent | MAINTAINERS: add maintainer for Renesas I2C related drivers (diff) | |
| download | linux-dev-1eace8344c02c625ee99cc3ffa50187ded2c87b5.tar.xz linux-dev-1eace8344c02c625ee99cc3ffa50187ded2c87b5.zip | |
i2c: add param sanity check to i2c_transfer()
The API docs describe i2c_transfer() as taking a pointer to an array
of i2c_msg containing at least 1 entry, but leaves it to the individual
drivers to sanity check the msgs and num parameters. Let's do this in
core code instead.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
[wsa: changed '<= 0' to '< 1']
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/i2c-core-base.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 1adeebaa81b0..1ba40bb2b966 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -1845,6 +1845,9 @@ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) unsigned long orig_jiffies; int ret, try; + if (WARN_ON(!msgs || num < 1)) + return -EINVAL; + if (adap->quirks && i2c_check_for_quirks(adap, msgs, num)) return -EOPNOTSUPP; |