aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/i2c
diff options
context:
space:
mode:
authorWolfram Sang <wsa+renesas@sang-engineering.com>2018-06-16 22:37:57 +0900
committerWolfram Sang <wsa@the-dreams.de>2018-06-29 08:19:51 +0200
commit2173ed0adc7f0473e6b6ad636d8684a0d82da5e9 (patch)
tree89aa50ce9c4c0bb0132b47801711dcd8294127c3 /drivers/i2c
parentRevert "i2c: algo-bit: init the bus to a known state" (diff)
downloadlinux-dev-2173ed0adc7f0473e6b6ad636d8684a0d82da5e9.tar.xz
linux-dev-2173ed0adc7f0473e6b6ad636d8684a0d82da5e9.zip
i2c: algos: bit: mention our experience about initial states
So, if somebody wants to re-implement this in the future, we pinpoint to a problem case. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c')
-rw-r--r--drivers/i2c/algos/i2c-algo-bit.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
index 0c0eb16d710f..6ec65adaba49 100644
--- a/drivers/i2c/algos/i2c-algo-bit.c
+++ b/drivers/i2c/algos/i2c-algo-bit.c
@@ -647,6 +647,11 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
if (bit_adap->getscl == NULL)
adap->quirks = &i2c_bit_quirk_no_clk_stretch;
+ /*
+ * We tried forcing SCL/SDA to an initial state here. But that caused a
+ * regression, sadly. Check Bugzilla #200045 for details.
+ */
+
ret = add_adapter(adap);
if (ret < 0)
return ret;