diff options
| author |   Jamie Iles <quic_jiles@quicinc.com> | 2021-09-22 17:57:18 +0100 |
|---|---|---|
| committer |   Wolfram Sang <wsa@kernel.org> | 2021-10-02 08:38:43 +0200 |
| commit | 6558b646ce1c2a872fe1c2c7cb116f05a2c1950f (patch) | |
| tree | a05a27004e04118d201ab11c3c411715c2e83412 /drivers/i2c | |
| parent | Linux 5.15-rc3 (diff) | |
| download | linux-dev-6558b646ce1c2a872fe1c2c7cb116f05a2c1950f.tar.xz linux-dev-6558b646ce1c2a872fe1c2c7cb116f05a2c1950f.zip | |
i2c: acpi: fix resource leak in reconfiguration device addition
acpi_i2c_find_adapter_by_handle() calls bus_find_device() which takes a
reference on the adapter which is never released which will result in a
reference count leak and render the adapter unremovable. Make sure to
put the adapter after creating the client in the same manner that we do
for OF.
Fixes: 525e6fabeae2 ("i2c / ACPI: add support for ACPI reconfigure notifications")
Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
[wsa: fixed title]
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/i2c-core-acpi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c index aaeeacc12121..546cc935e035 100644 --- a/drivers/i2c/i2c-core-acpi.c +++ b/drivers/i2c/i2c-core-acpi.c @@ -454,6 +454,7 @@ static int i2c_acpi_notify(struct notifier_block *nb, unsigned long value, break; i2c_acpi_register_device(adapter, adev, &info); + put_device(&adapter->dev); break; case ACPI_RECONFIG_DEVICE_REMOVE: if (!acpi_device_enumerated(adev)) |