aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/i2c
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2021-05-22 00:00:28 +0200
committerWolfram Sang <wsa@kernel.org>2021-05-27 22:08:36 +0200
commit78f420acc4231f7db99291d846bc73d5f8a8df72 (patch)
tree067bde3f100e0e91f60acc7c30eb304ea0f5fa83 /drivers/i2c
parenti2c: aspeed: disable additional device addresses on ast2[56]xx (diff)
downloadlinux-dev-78f420acc4231f7db99291d846bc73d5f8a8df72.tar.xz
linux-dev-78f420acc4231f7db99291d846bc73d5f8a8df72.zip
i2c: i801: Remove unneeded warning after wait_event_timeout timeout
When passing -ETIMEDOUT to i801_check_post() it will emit a timeout error message. I don't see much benefit in an additional warning stating more or less the same. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Jean Delvare <jdelvare@suse.de> Tested-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
-rw-r--r--drivers/i2c/busses/i2c-i801.c12
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 99d446763530..bfea94d02775 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -509,11 +509,9 @@ static int i801_transaction(struct i801_priv *priv, int xact)
result = wait_event_timeout(priv->waitq,
(status = priv->status),
adap->timeout);
- if (!result) {
+ if (!result)
status = -ETIMEDOUT;
- dev_warn(&priv->pci_dev->dev,
- "Timeout waiting for interrupt!\n");
- }
+
priv->status = 0;
return i801_check_post(priv, status);
}
@@ -732,11 +730,9 @@ static int i801_block_transaction_byte_by_byte(struct i801_priv *priv,
result = wait_event_timeout(priv->waitq,
(status = priv->status),
adap->timeout);
- if (!result) {
+ if (!result)
status = -ETIMEDOUT;
- dev_warn(&priv->pci_dev->dev,
- "Timeout waiting for interrupt!\n");
- }
+
priv->status = 0;
return i801_check_post(priv, status);
}