diff options
| author |   Lucas Stach <l.stach@pengutronix.de> | 2018-03-08 14:25:18 +0100 |
|---|---|---|
| committer |   Wolfram Sang <wsa@the-dreams.de> | 2018-04-03 15:29:28 +0200 |
| commit | d9a22d713acb484f9d60861598a71e28129c0afa (patch) | |
| tree | 737453064662c8287cc586e7fd605917835a4ec8 /drivers/i2c | |
| parent | i2c: imx: use clk notifier for rate changes (diff) | |
| download | linux-dev-d9a22d713acb484f9d60861598a71e28129c0afa.tar.xz linux-dev-d9a22d713acb484f9d60861598a71e28129c0afa.zip | |
i2c: imx: avoid taking clk_prepare mutex in PM callbacks
This is unsafe, as the runtime PM callbacks are called from the PM
workqueue, so this may deadlock when handling an i2c attached clock,
which may already hold the clk_prepare mutex from another context.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-imx.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index c9632b2f0eaa..d7267dd9c7bf 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -1226,7 +1226,7 @@ static int i2c_imx_runtime_suspend(struct device *dev) { struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev); - clk_disable_unprepare(i2c_imx->clk); + clk_disable(i2c_imx->clk); return 0; } @@ -1236,7 +1236,7 @@ static int i2c_imx_runtime_resume(struct device *dev) struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev); int ret; - ret = clk_prepare_enable(i2c_imx->clk); + ret = clk_enable(i2c_imx->clk); if (ret) dev_err(dev, "can't enable I2C clock, ret=%d\n", ret); |