diff options
| author |   Zhihao Cheng <chengzhihao1@huawei.com> | 2020-11-16 22:10:58 +0800 |
|---|---|---|
| committer |   Wolfram Sang <wsa@kernel.org> | 2020-12-02 16:42:09 +0100 |
| commit | e9acf0298c664f825e6f1158f2a97341bf9e03ca (patch) | |
| tree | 598df9087c525b729b63e21e4b6bb0edecc2cd83 /drivers/i2c | |
| parent | Linux 5.10-rc6 (diff) | |
| download | linux-dev-e9acf0298c664f825e6f1158f2a97341bf9e03ca.tar.xz linux-dev-e9acf0298c664f825e6f1158f2a97341bf9e03ca.zip | |
i2c: qup: Fix error return code in qup_i2c_bam_schedule_desc()
Fix to return the error code from qup_i2c_change_state()
instaed of 0 in qup_i2c_bam_schedule_desc().
Fixes: fbf9921f8b35d9b2 ("i2c: qup: Fix error handling")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-qup.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index fbc04b60cfd1..5a47915869ae 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -801,7 +801,8 @@ static int qup_i2c_bam_schedule_desc(struct qup_i2c_dev *qup) if (ret || qup->bus_err || qup->qup_err) { reinit_completion(&qup->xfer); - if (qup_i2c_change_state(qup, QUP_RUN_STATE)) { + ret = qup_i2c_change_state(qup, QUP_RUN_STATE); + if (ret) { dev_err(qup->dev, "change to run state timed out"); goto desc_err; } |