diff options
| author |   Sergey Shtylyov <s.shtylyov@omp.ru> | 2021-05-30 22:13:45 +0300 |
|---|---|---|
| committer |   Wolfram Sang <wsa@kernel.org> | 2021-08-03 22:48:39 +0200 |
| commit | f16a3bb69aa6baabf8f0aca982c8cf21e2a4f6bc (patch) | |
| tree | 376397094388028f38d4a14805898d5674284b0b /drivers/i2c | |
| parent | i2c: i801: Fix handling SMBHSTCNT_PEC_EN (diff) | |
| download | linux-dev-f16a3bb69aa6baabf8f0aca982c8cf21e2a4f6bc.tar.xz linux-dev-f16a3bb69aa6baabf8f0aca982c8cf21e2a4f6bc.zip | |
i2c: highlander: add IRQ check
The driver is written as if platform_get_irq() returns 0 on errors (while
actually it returns a negative error code), blithely passing these error
codes to request_irq() (which takes *unsigned* IRQ #) -- which fails with
-EINVAL. Add the necessary error check to the pre-existing *if* statement
forcing the driver into the polling mode...
Fixes: 4ad48e6ab18c ("i2c: Renesas Highlander FPGA SMBus support")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-highlander.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c index 803dad70e2a7..a2add128d084 100644 --- a/drivers/i2c/busses/i2c-highlander.c +++ b/drivers/i2c/busses/i2c-highlander.c @@ -379,7 +379,7 @@ static int highlander_i2c_probe(struct platform_device *pdev) platform_set_drvdata(pdev, dev); dev->irq = platform_get_irq(pdev, 0); - if (iic_force_poll) + if (dev->irq < 0 || iic_force_poll) dev->irq = 0; if (dev->irq) { |