diff options
| author |   Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2019-08-13 13:55:55 +0200 |
|---|---|---|
| committer |   Wolfram Sang <wsa@the-dreams.de> | 2019-09-03 20:01:13 +0200 |
| commit | f8c274e4a70e7cdc43db56e2391c485c580b5a43 (patch) | |
| tree | 2b38000fdb6637a470cc36e56f679a32e70c14a8 /drivers/i2c | |
| parent | i2c: i801: Use iTCO version 6 in Cannon Lake PCH and beyond (diff) | |
| download | linux-dev-f8c274e4a70e7cdc43db56e2391c485c580b5a43.tar.xz linux-dev-f8c274e4a70e7cdc43db56e2391c485c580b5a43.zip | |
i2c: hix5hd2: Remove IRQF_ONESHOT
The drivers sets IRQF_ONESHOT and passes only a primary handler. The IRQ
is masked while the primary is handler is invoked independently of
IRQF_ONESHOT.
With IRQF_ONESHOT the core code will not force-thread the interrupt and
this is probably not intended. I *assume* that the original author copied
the IRQ registration from another driver which passed a primary and
secondary handler and removed the secondary handler but keeping the
ONESHOT flag.
Remove IRQF_ONESHOT.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-hix5hd2.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c index 4df1434b3597..8497c7a95dd4 100644 --- a/drivers/i2c/busses/i2c-hix5hd2.c +++ b/drivers/i2c/busses/i2c-hix5hd2.c @@ -445,8 +445,7 @@ static int hix5hd2_i2c_probe(struct platform_device *pdev) hix5hd2_i2c_init(priv); ret = devm_request_irq(&pdev->dev, irq, hix5hd2_i2c_irq, - IRQF_NO_SUSPEND | IRQF_ONESHOT, - dev_name(&pdev->dev), priv); + IRQF_NO_SUSPEND, dev_name(&pdev->dev), priv); if (ret != 0) { dev_err(&pdev->dev, "cannot request HS-I2C IRQ %d\n", irq); goto err_clk; |