diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2020-11-24 12:35:04 +0000 |
|---|---|---|
| committer |   Boris Brezillon <boris.brezillon@collabora.com> | 2020-11-25 11:02:43 +0100 |
| commit | 8e3457372c6acd0a9310373de203c2a84b457418 (patch) | |
| tree | da4acda4b8d9182c9b6d35fe76da6943e148b10d /drivers/i3c | |
| parent | i3c/master: introduce the mipi-i3c-hci driver (diff) | |
| download | linux-dev-8e3457372c6acd0a9310373de203c2a84b457418.tar.xz linux-dev-8e3457372c6acd0a9310373de203c2a84b457418.zip | |
i3c/master: Fix uninitialized variable next_addr
The variable next_addr is not initialized and is being used in a call
to i3c_master_get_free_addr as a starting point to find the next address.
Fix this by initializing next_addr to 0 to avoid an uninitialized garbage
starting address from being used.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-i3c/20201124123504.396249-1-colin.king@canonical.com
Diffstat (limited to 'drivers/i3c')
| -rw-r--r-- | drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c index 6dd234a82892..d97c3175e0e2 100644 --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c @@ -293,7 +293,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci) { struct hci_xfer *xfer; int ret, dat_idx = -1; - u8 next_addr; + u8 next_addr = 0; u64 pid; unsigned int dcr, bcr; DECLARE_COMPLETION_ONSTACK(done); |