diff options
| author |   Christoph Hellwig <hch@lst.de> | 2017-04-20 16:02:55 +0200 |
|---|---|---|
| committer |   Jens Axboe <axboe@fb.com> | 2017-04-20 12:16:10 -0600 |
| commit | b7819b9259185dcdcc81eb32182a4dc13d695738 (patch) | |
| tree | 96d76ffadf2718b65faf6004b734ed6b094f30ae /drivers/ide/ide-cd_ioctl.c | |
| parent | pd: don't check blk_execute_rq return value. (diff) | |
| download | linux-dev-b7819b9259185dcdcc81eb32182a4dc13d695738.tar.xz linux-dev-b7819b9259185dcdcc81eb32182a4dc13d695738.zip | |
block: remove the blk_execute_rq return value
The function only returns -EIO if rq->errors is non-zero, which is not
very useful and lets a large number of callers ignore the return value.
Just let the callers figure out their error themselves.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/ide/ide-cd_ioctl.c')
| -rw-r--r-- | drivers/ide/ide-cd_ioctl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ide/ide-cd_ioctl.c b/drivers/ide/ide-cd_ioctl.c index 9fcefbc8425e..f1ab726bd430 100644 --- a/drivers/ide/ide-cd_ioctl.c +++ b/drivers/ide/ide-cd_ioctl.c @@ -307,7 +307,8 @@ int ide_cdrom_reset(struct cdrom_device_info *cdi) scsi_req_init(rq); ide_req(rq)->type = ATA_PRIV_MISC; rq->rq_flags = RQF_QUIET; - ret = blk_execute_rq(drive->queue, cd->disk, rq, 0); + blk_execute_rq(drive->queue, cd->disk, rq, 0); + ret = rq->errors ? -EIO : 0; blk_put_request(rq); /* * A reset will unlock the door. If it was previously locked, |