diff options
| author |   Mikulas Patocka <mpatocka@redhat.com> | 2017-04-14 14:35:33 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-05-08 17:36:39 -0400 |
| commit | acfead32f3f938e456d7d5e1a82c743d30b8b886 (patch) | |
| tree | e8c6f42c1337180b2fa41430476fa873bf56f3cd /drivers/ide | |
| parent | ide: use setup_timer (diff) | |
| download | linux-dev-acfead32f3f938e456d7d5e1a82c743d30b8b886.tar.xz linux-dev-acfead32f3f938e456d7d5e1a82c743d30b8b886.zip | |
ide: don't call memcpy with the same source and destination
The parisc architecture recently reimplemented the memcpy function and
their reimplementation crashed when source and destination overlapped.
The crash happened in the function ide_complete_cmd where memcpy is called
with the same source and destination pointer. According to the C
specification, memcpy behavior is undefined if the source and destination
range overlaps. This patches fixes the undefined behavior.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ide')
| -rw-r--r-- | drivers/ide/ide-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index 45b3f41a43d4..323af721f8cb 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c @@ -107,7 +107,7 @@ void ide_complete_cmd(ide_drive_t *drive, struct ide_cmd *cmd, u8 stat, u8 err) if (cmd->tf_flags & IDE_TFLAG_DYN) kfree(orig_cmd); - else + else if (cmd != orig_cmd) memcpy(orig_cmd, cmd, sizeof(*cmd)); } } |