diff options
| author |   Krzysztof Kozlowski <krzk@kernel.org> | 2020-08-29 08:47:18 +0200 |
|---|---|---|
| committer |   Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2020-09-03 19:40:50 +0100 |
| commit | 8facae29c468bd4ac1cabb440cdbac47ac9ac9e1 (patch) | |
| tree | 536ed5b329b8b256b234f56fb61d7c86fbc2ed2c /drivers/iio/amplifiers | |
| parent | iio: afe: iio-rescale: Simplify with dev_err_probe() (diff) | |
| download | linux-dev-8facae29c468bd4ac1cabb440cdbac47ac9ac9e1.tar.xz linux-dev-8facae29c468bd4ac1cabb440cdbac47ac9ac9e1.zip | |
iio: amplifiers: hmc425a: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200829064726.26268-10-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/amplifiers')
| -rw-r--r-- | drivers/iio/amplifiers/hmc425a.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index 582708924e4f..9efa692151f0 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -201,12 +201,9 @@ static int hmc425a_probe(struct platform_device *pdev) st->gain = st->chip_info->default_gain; st->gpios = devm_gpiod_get_array(&pdev->dev, "ctrl", GPIOD_OUT_LOW); - if (IS_ERR(st->gpios)) { - ret = PTR_ERR(st->gpios); - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, "failed to get gpios\n"); - return ret; - } + if (IS_ERR(st->gpios)) + return dev_err_probe(&pdev->dev, PTR_ERR(st->gpios), + "failed to get gpios\n"); if (st->gpios->ndescs != st->chip_info->num_gpios) { dev_err(&pdev->dev, "%d GPIOs needed to operate\n", |