aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/iio/dac/ad5592r-base.c
diff options
context:
space:
mode:
authorJose Cazarin <joseespiriki@gmail.com>2022-03-25 01:43:40 +0200
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2022-04-04 09:19:01 +0100
commita2a43fd9d84aec15f8c3dc434d50cd59d8a116b2 (patch)
treeedc5049d96df553b90005b855542144ae49dcc96 /drivers/iio/dac/ad5592r-base.c
parentiio:imu:bmi160: disable regulator in error path (diff)
downloadlinux-dev-a2a43fd9d84aec15f8c3dc434d50cd59d8a116b2.tar.xz
linux-dev-a2a43fd9d84aec15f8c3dc434d50cd59d8a116b2.zip
iio: dac: dac5571: Fix chip id detection for OF devices
When matching an OF device, the match mechanism tries all components of the compatible property. This can result with a device matched with a compatible string that isn't the first in the compatible list. For instance, with a compatible property set to compatible = "ti,dac081c081", "ti,dac5571"; the driver will match the second compatible string, as the first one isn't listed in the of_device_id table. The device will however be named "dac081c081" by the I2C core. This causes an issue when identifying the chip. The probe function receives a i2c_device_id that comes from the module's I2C device ID table. There is no entry in that table for "dac081c081", which results in a NULL pointer passed to the probe function. To fix this, add chip_id information in the data field of the OF device ID table, and retrieve it with device_get_match_data() for OF devices. Signed-off-by: Jose Cazarin <joseespiriki@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Link: https://lore.kernel.org/r/20220324234340.32402-1-laurent.pinchart@ideasonboard.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/dac/ad5592r-base.c')
0 files changed, 0 insertions, 0 deletions