aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/iio/light/vcnl4000.c
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2021-05-09 12:33:47 +0100
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2021-05-17 13:54:27 +0100
commitdb27fdb33d10b582371f2be294d2b6b2ca501043 (patch)
tree0e81c5c777de48db82a89172e9b2d94e507d3fe4 /drivers/iio/light/vcnl4000.c
parentiio: proximity: srf04: Use pm_runtime_resume_and_get() and handle error (diff)
downloadlinux-dev-db27fdb33d10b582371f2be294d2b6b2ca501043.tar.xz
linux-dev-db27fdb33d10b582371f2be294d2b6b2ca501043.zip
iio: light: vcnl4000: Use pm_runtime_resume_and_get() to replace open coding.
Found using coccicheck script under review at: https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ This is a prequel to taking a closer look at the runtime pm in IIO drivers in general. Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: Mathieu Othacehe <m.othacehe@gmail.com> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/20210509113354.660190-22-jic23@kernel.org
Diffstat (limited to 'drivers/iio/light/vcnl4000.c')
-rw-r--r--drivers/iio/light/vcnl4000.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 4a61865d01cd..01772327a947 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -413,9 +413,7 @@ static int vcnl4000_set_pm_runtime_state(struct vcnl4000_data *data, bool on)
int ret;
if (on) {
- ret = pm_runtime_get_sync(dev);
- if (ret < 0)
- pm_runtime_put_noidle(dev);
+ ret = pm_runtime_resume_and_get(dev);
} else {
pm_runtime_mark_last_busy(dev);
ret = pm_runtime_put_autosuspend(dev);