diff options
| author |   Alexandru Ardelean <alexandru.ardelean@analog.com> | 2019-11-01 11:35:00 +0200 |
|---|---|---|
| committer |   Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2019-11-03 10:29:25 +0000 |
| commit | 6a39ab3b195c125d3fe49d0b0b613c2e1dbbc5a2 (patch) | |
| tree | 2f91043d89c8d5a42865fd98a5625b7b0e83566d /drivers/iio | |
| parent | iio: imu: adis16480: check ret val for non-zero vs less-than-zero (diff) | |
| download | linux-dev-6a39ab3b195c125d3fe49d0b0b613c2e1dbbc5a2.tar.xz linux-dev-6a39ab3b195c125d3fe49d0b0b613c2e1dbbc5a2.zip | |
iio: imu: adis: check ret val for non-zero vs less-than-zero
The ADIS library functions return zero on success, and negative values for
error. Positive values aren't returned, but we only care about the success
value (which is zero).
This change is mostly needed so that the compiler won't make any inferences
about some about values being potentially un-initialized. This only
triggers after making some functions inline, because the compiler can
better follow return paths.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
| -rw-r--r-- | drivers/iio/imu/adis.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c index 1631c255deab..dc2f9e061d98 100644 --- a/drivers/iio/imu/adis.c +++ b/drivers/iio/imu/adis.c @@ -286,7 +286,7 @@ int adis_check_status(struct adis *adis) int i; ret = adis_read_reg_16(adis, adis->data->diag_stat_reg, &status); - if (ret < 0) + if (ret) return ret; status &= adis->data->status_error_mask; |