diff options
| author |   Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2021-06-13 16:22:56 +0100 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2021-06-14 11:42:41 +0100 |
| commit | 6a6be221b8bd561b053f0701ec752a5ed9007f69 (patch) | |
| tree | 4d9fb82e9b0aa905b47f4f3b265a0974ac850986 /drivers/iio | |
| parent | iio: adc: hx711: Fix buffer alignment in iio_push_to_buffers_with_timestamp() (diff) | |
| download | linux-dev-6a6be221b8bd561b053f0701ec752a5ed9007f69.tar.xz linux-dev-6a6be221b8bd561b053f0701ec752a5ed9007f69.zip | |
iio: adc: mxs-lradc: Fix buffer alignment in iio_push_to_buffers_with_timestamp()
To make code more readable, use a structure to express the channel
layout and ensure the timestamp is 8 byte aligned.
Add a comment on why the buffer is the size it is as not immediately
obvious.
Found during an audit of all calls of this function.
Fixes: 6dd112b9f85e ("iio: adc: mxs-lradc: Add support for ADC driver")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Andreas Klinger <ak@it-klinger.de>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210613152301.571002-4-jic23@kernel.org
Diffstat (limited to 'drivers/iio')
| -rw-r--r-- | drivers/iio/adc/mxs-lradc-adc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c index 1d99170d3328..bca79a93cbe4 100644 --- a/drivers/iio/adc/mxs-lradc-adc.c +++ b/drivers/iio/adc/mxs-lradc-adc.c @@ -115,7 +115,8 @@ struct mxs_lradc_adc { struct device *dev; void __iomem *base; - u32 buffer[10]; + /* Maximum of 8 channels + 8 byte ts */ + u32 buffer[10] __aligned(8); struct iio_trigger *trig; struct completion completion; spinlock_t lock; |