aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/iio
diff options
context:
space:
mode:
authorChuhong Yuan <hslester96@gmail.com>2019-08-01 15:35:57 +0800
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2019-08-05 16:23:47 +0100
commit6b9ab1cf4b21b92c4b3bbebe1b5dc4f6d44f35b6 (patch)
tree04e9fb5c7094d7e9ea2c89691428f76fd50809e4 /drivers/iio
parentiio: Remove dev_err() usage after platform_get_irq() (diff)
downloadlinux-dev-6b9ab1cf4b21b92c4b3bbebe1b5dc4f6d44f35b6.tar.xz
linux-dev-6b9ab1cf4b21b92c4b3bbebe1b5dc4f6d44f35b6.zip
iio: tsl2772: Use devm_add_action_or_reset
Use devm_add_action_or_reset to remove the call to tsl2772_disable_regulators_action to simplify the error path. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Reviewed-by: Brian Masney <masneyb@onstation.org> Tested-by: Brian Masney <masneyb@onstation.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio')
-rw-r--r--drivers/iio/light/tsl2772.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index 83cece921843..29cfd8ae2700 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -1807,10 +1807,10 @@ static int tsl2772_probe(struct i2c_client *clientp,
return PTR_ERR(chip->vdd_supply);
}
- ret = devm_add_action(&clientp->dev, tsl2772_disable_regulators_action,
- chip);
+ ret = devm_add_action_or_reset(&clientp->dev,
+ tsl2772_disable_regulators_action,
+ chip);
if (ret < 0) {
- tsl2772_disable_regulators_action(chip);
dev_err(&clientp->dev, "Failed to setup regulator cleanup action %d\n",
ret);
return ret;