diff options
| author |   Miaoqian Lin <linmq006@gmail.com> | 2022-06-21 09:25:44 +0400 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@nvidia.com> | 2022-06-24 16:41:03 -0300 |
| commit | 2990f223ffa7bb25422956b9f79f9176a5b38346 (patch) | |
| tree | dd5408fe289a66d3806a1545019e81b0f7d2acb8 /drivers/infiniband/core/cm.c | |
| parent | RDMA/qedr: Fix reporting QP timeout attribute (diff) | |
| download | linux-dev-2990f223ffa7bb25422956b9f79f9176a5b38346.tar.xz linux-dev-2990f223ffa7bb25422956b9f79f9176a5b38346.zip | |
RDMA/cm: Fix memory leak in ib_cm_insert_listen
cm_alloc_id_priv() allocates resource for the cm_id_priv. When
cm_init_listen() fails it doesn't free it, leading to memory leak.
Add the missing error unwind.
Fixes: 98f67156a80f ("RDMA/cm: Simplify establishing a listen cm_id")
Link: https://lore.kernel.org/r/20220621052546.4821-1-linmq006@gmail.com
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'drivers/infiniband/core/cm.c')
| -rw-r--r-- | drivers/infiniband/core/cm.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index 1c107d6d03b9..b985e0d9bc05 100644 --- a/drivers/infiniband/core/cm.c +++ b/drivers/infiniband/core/cm.c @@ -1252,8 +1252,10 @@ struct ib_cm_id *ib_cm_insert_listen(struct ib_device *device, return ERR_CAST(cm_id_priv); err = cm_init_listen(cm_id_priv, service_id, 0); - if (err) + if (err) { + ib_destroy_cm_id(&cm_id_priv->id); return ERR_PTR(err); + } spin_lock_irq(&cm_id_priv->lock); listen_id_priv = cm_insert_listen(cm_id_priv, cm_handler); |