diff options
| author |   Maor Gottlieb <maorg@mellanox.com> | 2020-05-21 10:26:50 +0300 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@mellanox.com> | 2020-05-22 15:37:19 -0300 |
| commit | 63a3345c2d42a9b29e1ce2d3a4043689b3995cea (patch) | |
| tree | a7e84e74dce147daff8a151793d58140c1ca3945 /drivers/infiniband/core/cma_configfs.c | |
| parent | block/rnbd: Fix an IS_ERR() vs NULL check in find_or_create_sess() (diff) | |
| download | linux-dev-63a3345c2d42a9b29e1ce2d3a4043689b3995cea.tar.xz linux-dev-63a3345c2d42a9b29e1ce2d3a4043689b3995cea.zip | |
IB/cma: Fix ports memory leak in cma_configfs
The allocated ports structure in never freed. The free function should be
called by release_cma_ports_group, but the group is never released since
we don't remove its default group.
Remove default groups when device group is deleted.
Fixes: 045959db65c6 ("IB/cma: Add configfs for rdma_cm")
Link: https://lore.kernel.org/r/20200521072650.567908-1-leon@kernel.org
Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/core/cma_configfs.c')
| -rw-r--r-- | drivers/infiniband/core/cma_configfs.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/drivers/infiniband/core/cma_configfs.c b/drivers/infiniband/core/cma_configfs.c index c672a4978bfd..3c1e2ca564fe 100644 --- a/drivers/infiniband/core/cma_configfs.c +++ b/drivers/infiniband/core/cma_configfs.c @@ -322,8 +322,21 @@ fail: return ERR_PTR(err); } +static void drop_cma_dev(struct config_group *cgroup, struct config_item *item) +{ + struct config_group *group = + container_of(item, struct config_group, cg_item); + struct cma_dev_group *cma_dev_group = + container_of(group, struct cma_dev_group, device_group); + + configfs_remove_default_groups(&cma_dev_group->ports_group); + configfs_remove_default_groups(&cma_dev_group->device_group); + config_item_put(item); +} + static struct configfs_group_operations cma_subsys_group_ops = { .make_group = make_cma_dev, + .drop_item = drop_cma_dev, }; static const struct config_item_type cma_subsys_type = { |