diff options
| author |   Jason Gunthorpe <jgg@mellanox.com> | 2018-02-13 12:18:30 +0200 |
|---|---|---|
| committer | Jason Gunthorpe <jgg@mellanox.com> | 2018-02-15 14:59:44 -0700 |
| commit | 6c976c30ad1c205bd6e34182c5ba9a1267d752ca (patch) | |
| tree | 067a09af8ce5420766a1e8c6f7af8c1315a355d5 /drivers/infiniband/core/uverbs_std_types.c | |
| parent | IB/uverbs: Always use the attribute size provided by the user (diff) | |
| download | linux-dev-6c976c30ad1c205bd6e34182c5ba9a1267d752ca.tar.xz linux-dev-6c976c30ad1c205bd6e34182c5ba9a1267d752ca.zip | |
IB/uverbs: Use inline data transfer for UHW_IN
The rule for the API is pointers less than 8 bytes are inlined into
the .data field of the attribute. Fix the creation of the driver udata
struct to follow this rule and point to the .data itself when the size
is less than 8 bytes.
Otherwise if the UHW struct is less than 8 bytes the driver will get
EFAULT during copy_from_user.
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/core/uverbs_std_types.c')
| -rw-r--r-- | drivers/infiniband/core/uverbs_std_types.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/infiniband/core/uverbs_std_types.c b/drivers/infiniband/core/uverbs_std_types.c index c6502c7b7c46..7b0e4d778d79 100644 --- a/drivers/infiniband/core/uverbs_std_types.c +++ b/drivers/infiniband/core/uverbs_std_types.c @@ -234,8 +234,11 @@ static void create_udata(struct uverbs_attr_bundle *ctx, uverbs_attr_get(ctx, UVERBS_UHW_OUT); if (!IS_ERR(uhw_in)) { - udata->inbuf = uhw_in->ptr_attr.ptr; udata->inlen = uhw_in->ptr_attr.len; + if (uverbs_attr_ptr_is_inline(uhw_in)) + udata->inbuf = &uhw_in->uattr->data; + else + udata->inbuf = uhw_in->ptr_attr.ptr; } else { udata->inbuf = NULL; udata->inlen = 0; |