diff options
| author |   Gerd Rausch <gerd.rausch@oracle.com> | 2021-06-24 11:55:31 -0700 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@nvidia.com> | 2021-06-25 12:00:19 -0300 |
| commit | 74f160ead74bfe5f2b38afb4fcf86189f9ff40c9 (patch) | |
| tree | 036d474b1a7a4c59b137c3ae7a0f3521350e4946 /drivers/infiniband/core | |
| parent | RDMA/core/sa_query: Remove unused argument (diff) | |
| download | linux-dev-74f160ead74bfe5f2b38afb4fcf86189f9ff40c9.tar.xz linux-dev-74f160ead74bfe5f2b38afb4fcf86189f9ff40c9.zip | |
RDMA/cma: Fix rdma_resolve_route() memory leak
Fix a memory leak when "mda_resolve_route() is called more than once on
the same "rdma_cm_id".
This is possible if cma_query_handler() triggers the
RDMA_CM_EVENT_ROUTE_ERROR flow which puts the state machine back and
allows rdma_resolve_route() to be called again.
Link: https://lore.kernel.org/r/f6662b7b-bdb7-2706-1e12-47c61d3474b6@oracle.com
Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'drivers/infiniband/core')
| -rw-r--r-- | drivers/infiniband/core/cma.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 9dfb07a16ab1..420de383c039 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -2814,7 +2814,8 @@ static int cma_resolve_ib_route(struct rdma_id_private *id_priv, cma_init_resolve_route_work(work, id_priv); - route->path_rec = kmalloc(sizeof *route->path_rec, GFP_KERNEL); + if (!route->path_rec) + route->path_rec = kmalloc(sizeof *route->path_rec, GFP_KERNEL); if (!route->path_rec) { ret = -ENOMEM; goto err1; |