diff options
| author |   Yann Droneaud <ydroneaud@opteya.com> | 2013-12-11 23:01:50 +0100 |
|---|---|---|
| committer |   Roland Dreier <roland@purestorage.com> | 2013-12-20 10:54:33 -0800 |
| commit | 98a37510ec1452817600d8ea47cff1d9f8d9bec8 (patch) | |
| tree | 90b321acf45da2e3aafc2f3e80b9a3c6ef775567 /drivers/infiniband/core | |
| parent | IB/uverbs: Check reserved fields in create_flow (diff) | |
| download | linux-dev-98a37510ec1452817600d8ea47cff1d9f8d9bec8.tar.xz linux-dev-98a37510ec1452817600d8ea47cff1d9f8d9bec8.zip | |
IB/uverbs: Set error code when fail to consume all flow_spec items
If the flow_spec items parsed count does not match the number of items
declared in the flow_attr command, or if not all bytes are used for
flow_spec items (eg. trailing garbage), a log message is reported and
the function leave through the error path. Unfortunately the error
code is currently not set.
This patch set error code to -EINVAL in such cases, so that the error
is reported to userspace instead of silently fail.
Link: http://marc.info/?i=cover.1386798254.git.ydroneaud@opteya.com>
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband/core')
| -rw-r--r-- | drivers/infiniband/core/uverbs_cmd.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c index 4e8b15c50481..45fb80b876b0 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -2738,6 +2738,7 @@ int ib_uverbs_ex_create_flow(struct ib_uverbs_file *file, if (cmd.flow_attr.size || (i != flow_attr->num_of_specs)) { pr_warn("create flow failed, flow %d: %d bytes left from uverb cmd\n", i, cmd.flow_attr.size); + err = -EINVAL; goto err_free; } flow_id = ib_create_flow(qp, flow_attr, IB_FLOW_DOMAIN_USER); |