diff options
| author |   Bart Van Assche <bart.vanassche@sandisk.com> | 2016-11-21 10:22:17 -0800 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2016-12-14 13:27:34 -0500 |
| commit | d3a2418ee36a59bc02e9d454723f3175dcf4bfd9 (patch) | |
| tree | 104f2825587b27107eb55cee9be731fc16a242c8 /drivers/infiniband/core | |
| parent | IPoIB: Avoid reading an uninitialized member variable (diff) | |
| download | linux-dev-d3a2418ee36a59bc02e9d454723f3175dcf4bfd9.tar.xz linux-dev-d3a2418ee36a59bc02e9d454723f3175dcf4bfd9.zip | |
IB/multicast: Check ib_find_pkey() return value
This patch avoids that Coverity complains about not checking the
ib_find_pkey() return value.
Fixes: commit 547af76521b3 ("IB/multicast: Report errors on multicast groups if P_key changes")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/core')
| -rw-r--r-- | drivers/infiniband/core/multicast.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/infiniband/core/multicast.c b/drivers/infiniband/core/multicast.c index e51b739f6ea3..322cb67b07a9 100644 --- a/drivers/infiniband/core/multicast.c +++ b/drivers/infiniband/core/multicast.c @@ -518,8 +518,11 @@ static void join_handler(int status, struct ib_sa_mcmember_rec *rec, process_join_error(group, status); else { int mgids_changed, is_mgid0; - ib_find_pkey(group->port->dev->device, group->port->port_num, - be16_to_cpu(rec->pkey), &pkey_index); + + if (ib_find_pkey(group->port->dev->device, + group->port->port_num, be16_to_cpu(rec->pkey), + &pkey_index)) + pkey_index = MCAST_INVALID_PKEY_INDEX; spin_lock_irq(&group->port->lock); if (group->state == MCAST_BUSY && |