diff options
| author |   Shamir Rabinovitch <shamir.rabinovitch@oracle.com> | 2018-04-10 10:26:23 -0400 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@mellanox.com> | 2018-04-16 09:49:24 -0600 |
| commit | ef95a90ae6f4f21990e1f7ced6719784a409e811 (patch) | |
| tree | 0ac674deb491b364a271fc90334688f8af3aa975 /drivers/infiniband/core | |
| parent | Linux 4.17-rc1 (diff) | |
| download | linux-dev-ef95a90ae6f4f21990e1f7ced6719784a409e811.tar.xz linux-dev-ef95a90ae6f4f21990e1f7ced6719784a409e811.zip | |
RDMA/ucma: ucma_context reference leak in error path
Validating input parameters should be done before getting the cm_id
otherwise it can leak a cm_id reference.
Fixes: 6a21dfc0d0db ("RDMA/ucma: Limit possible option size")
Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/core')
| -rw-r--r-- | drivers/infiniband/core/ucma.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 74329483af6d..680b3536ad3e 100644 --- a/drivers/infiniband/core/ucma.c +++ b/drivers/infiniband/core/ucma.c @@ -1316,13 +1316,13 @@ static ssize_t ucma_set_option(struct ucma_file *file, const char __user *inbuf, if (copy_from_user(&cmd, inbuf, sizeof(cmd))) return -EFAULT; + if (unlikely(cmd.optlen > KMALLOC_MAX_SIZE)) + return -EINVAL; + ctx = ucma_get_ctx(file, cmd.id); if (IS_ERR(ctx)) return PTR_ERR(ctx); - if (unlikely(cmd.optlen > KMALLOC_MAX_SIZE)) - return -EINVAL; - optval = memdup_user(u64_to_user_ptr(cmd.optval), cmd.optlen); if (IS_ERR(optval)) { |