diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2013-12-29 23:47:29 +0100 |
|---|---|---|
| committer |   Roland Dreier <roland@purestorage.com> | 2014-02-12 11:11:46 -0800 |
| commit | ab576627c8f97c08297d81537be17df161171923 (patch) | |
| tree | 35efe679c9f82ed9ec91fdfb493a03b59a497b2c /drivers/infiniband/hw/amso1100/c2_rnic.c | |
| parent | Linus 3.14-rc1 (diff) | |
| download | linux-dev-ab576627c8f97c08297d81537be17df161171923.tar.xz linux-dev-ab576627c8f97c08297d81537be17df161171923.zip | |
RDMA/amso1100: Fix error return code
Set the return variable to an error code as done elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband/hw/amso1100/c2_rnic.c')
| -rw-r--r-- | drivers/infiniband/hw/amso1100/c2_rnic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/amso1100/c2_rnic.c b/drivers/infiniband/hw/amso1100/c2_rnic.c index b7c986990053..d2a6d961344b 100644 --- a/drivers/infiniband/hw/amso1100/c2_rnic.c +++ b/drivers/infiniband/hw/amso1100/c2_rnic.c @@ -576,7 +576,8 @@ int c2_rnic_init(struct c2_dev *c2dev) goto bail4; /* Initialize cached the adapter limits */ - if (c2_rnic_query(c2dev, &c2dev->props)) + err = c2_rnic_query(c2dev, &c2dev->props); + if (err) goto bail5; /* Initialize the PD pool */ |