aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/hw/cxgb4/id_table.c
diff options
context:
space:
mode:
authorSteve Wise <swise@opengridcomputing.com>2017-11-02 14:11:03 -0700
committerDoug Ledford <dledford@redhat.com>2017-11-13 15:01:25 -0500
commitba97b749979ef0ebb821e58ee8b16a84412922f6 (patch)
tree84f151ef1ef1931a5fc6512ea3fbce637770a4a9 /drivers/infiniband/hw/cxgb4/id_table.c
parentbnxt_re: changing the ip address shouldn't affect new connections (diff)
downloadlinux-dev-ba97b749979ef0ebb821e58ee8b16a84412922f6.tar.xz
linux-dev-ba97b749979ef0ebb821e58ee8b16a84412922f6.zip
iw_cxgb4: remove BUG_ON() usage.
iw_cxgb4 has many BUG_ON()s that were left over from various enhancemnets made over the years. Almost all of them should just be removed. Some, however indicate a ULP usage error and can be handled w/o bringing down the system. If the condition cannot happen with correctly implemented cxgb4 sw/fw, then remove the BUG_ON. If the condition indicates a misbehaving ULP (like CQ overflows), add proper recovery logic. Signed-off-by: Steve Wise <swise@opengridcomputing.com> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/hw/cxgb4/id_table.c')
-rw-r--r--drivers/infiniband/hw/cxgb4/id_table.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/cxgb4/id_table.c b/drivers/infiniband/hw/cxgb4/id_table.c
index 0161ae6ad629..5c2cfdea06ad 100644
--- a/drivers/infiniband/hw/cxgb4/id_table.c
+++ b/drivers/infiniband/hw/cxgb4/id_table.c
@@ -73,7 +73,6 @@ void c4iw_id_free(struct c4iw_id_table *alloc, u32 obj)
unsigned long flags;
obj -= alloc->start;
- BUG_ON((int)obj < 0);
spin_lock_irqsave(&alloc->lock, flags);
clear_bit(obj, alloc->table);