aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/hw/hfi1/firmware.c
diff options
context:
space:
mode:
authorWang Wensheng <wangwensheng4@huawei.com>2021-04-08 11:31:40 +0000
committerJason Gunthorpe <jgg@nvidia.com>2021-04-12 15:10:19 -0300
commit4c7d9c69adadfc31892c7e8e134deb3546552106 (patch)
tree3b2d1aa541f0665d806d2e6cdec10ee6b8df364b /drivers/infiniband/hw/hfi1/firmware.c
parentRDMA/qedr: Fix error return code in qedr_iw_connect() (diff)
downloadlinux-dev-4c7d9c69adadfc31892c7e8e134deb3546552106.tar.xz
linux-dev-4c7d9c69adadfc31892c7e8e134deb3546552106.zip
IB/hfi1: Fix error return code in parse_platform_config()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 7724105686e7 ("IB/hfi1: add driver files") Link: https://lore.kernel.org/r/20210408113140.103032-1-wangwensheng4@huawei.com Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'drivers/infiniband/hw/hfi1/firmware.c')
-rw-r--r--drivers/infiniband/hw/hfi1/firmware.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
index 0e83d4b61e46..2cf102b5abd4 100644
--- a/drivers/infiniband/hw/hfi1/firmware.c
+++ b/drivers/infiniband/hw/hfi1/firmware.c
@@ -1916,6 +1916,7 @@ int parse_platform_config(struct hfi1_devdata *dd)
dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n",
__func__, (ptr -
(u32 *)dd->platform_config.data));
+ ret = -EINVAL;
goto bail;
}
/* Jump the CRC DWORD */