diff options
| author |   Faisal Latif <flatif@neteffect.com> | 2008-02-21 08:31:22 -0600 |
|---|---|---|
| committer |   Roland Dreier <rolandd@cisco.com> | 2008-02-26 16:24:29 -0800 |
| commit | 30da7cff87f0ffa169fe07b766c3d6a5f6d1f6ab (patch) | |
| tree | e68206af4e17a9542b978ca97aaca1a373ba8349 /drivers/infiniband/hw/nes/nes.h | |
| parent | RDMA/nes: Fix use-after-free in mini_cm_dec_refcnt_listen() (diff) | |
| download | linux-dev-30da7cff87f0ffa169fe07b766c3d6a5f6d1f6ab.tar.xz linux-dev-30da7cff87f0ffa169fe07b766c3d6a5f6d1f6ab.zip | |
RDMA/nes: Fix CRC endianness for RDMA connection establishment on big-endian
With commit ef19454b ("[LIB] crc32c: Keep intermediate crc state in
cpu order"), the behavior of crc32c changes on big-endian platforms.
Our algorithm expects the previous behavior; otherwise we have RDMA
connection establishment failure on big-endian platforms like powerpc.
Apply cpu_to_le32() to value returned by crc32c() to get the previous
behavior.
Signed-off-by: Faisal Latif <flatif@neteffect.com>
Signed-off-by: Glenn Streiff <gstreiff@neteffect.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband/hw/nes/nes.h')
| -rw-r--r-- | drivers/infiniband/hw/nes/nes.h | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h index fd57e8a1582f..a48b288618ec 100644 --- a/drivers/infiniband/hw/nes/nes.h +++ b/drivers/infiniband/hw/nes/nes.h @@ -285,6 +285,21 @@ struct nes_device { }; +static inline __le32 get_crc_value(struct nes_v4_quad *nes_quad) +{ + u32 crc_value; + crc_value = crc32c(~0, (void *)nes_quad, sizeof (struct nes_v4_quad)); + + /* + * With commit ef19454b ("[LIB] crc32c: Keep intermediate crc + * state in cpu order"), behavior of crc32c changes on + * big-endian platforms. Our algorithm expects the previous + * behavior; otherwise we have RDMA connection establishment + * issue on big-endian. + */ + return cpu_to_le32(crc_value); +} + static inline void set_wqe_64bit_value(__le32 *wqe_words, u32 index, u64 value) { |