diff options
| author |   Michael Mera <dev@michaelmera.com> | 2017-05-01 15:41:16 +0900 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2017-05-01 15:04:23 -0400 |
| commit | 062d0f22a30c39840ea49b72cfcfc1aa4cc538fa (patch) | |
| tree | 828b88cd5adbbeac367ec477ec502c294eb05949 /drivers/infiniband/hw/ocrdma/ocrdma_stats.c | |
| parent | IB/mlx4: Fix incorrect order of formal and actual parameters (diff) | |
| download | linux-dev-062d0f22a30c39840ea49b72cfcfc1aa4cc538fa.tar.xz linux-dev-062d0f22a30c39840ea49b72cfcfc1aa4cc538fa.zip | |
IB/ocrdma: fix out of bounds access to local buffer
In write to debugfs file 'resource_stats' the local buffer 'tmp_str' is
written at index 'count-1' where 'count' is the size of the write, so
potentially 0.
This patch filters odd values for the write size/position to avoid this
type of problem.
Signed-off-by: Michael Mera <dev@michaelmera.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/hw/ocrdma/ocrdma_stats.c')
| -rw-r--r-- | drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c index f8e4b0a6486f..66056f9a9700 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c @@ -643,7 +643,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp, struct ocrdma_stats *pstats = filp->private_data; struct ocrdma_dev *dev = pstats->dev; - if (count > 32) + if (*ppos != 0 || count == 0 || count > sizeof(tmp_str)) goto err; if (copy_from_user(tmp_str, buffer, count)) |