diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2021-06-25 16:03:06 +0300 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@nvidia.com> | 2021-06-25 12:00:28 -0300 |
| commit | 36941dfe0e8c3e2da7851b9648fd74bd3a3e78ce (patch) | |
| tree | 87d0dd4d4f8de72d57cf6c4583b9e28cbc02b955 /drivers/infiniband/sw | |
| parent | RDMA/cma: Fix rdma_resolve_route() memory leak (diff) | |
| download | linux-dev-36941dfe0e8c3e2da7851b9648fd74bd3a3e78ce.tar.xz linux-dev-36941dfe0e8c3e2da7851b9648fd74bd3a3e78ce.zip | |
RDMA/rxe: Missing unlock on error in get_srq_wqe()
This error path needs to unlock before returning.
Fixes: ec0fa2445c18 ("RDMA/rxe: Fix over copying in get_srq_wqe")
Link: https://lore.kernel.org/r/YNXUCmnPsSkPyhkm@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Majd Dibbiny <majd@nvidia.com>
Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'drivers/infiniband/sw')
| -rw-r--r-- | drivers/infiniband/sw/rxe/rxe_resp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c index 72cdb170b67b..3743dc39b60c 100644 --- a/drivers/infiniband/sw/rxe/rxe_resp.c +++ b/drivers/infiniband/sw/rxe/rxe_resp.c @@ -314,6 +314,7 @@ static enum resp_states get_srq_wqe(struct rxe_qp *qp) /* don't trust user space data */ if (unlikely(wqe->dma.num_sge > srq->rq.max_sge)) { + spin_unlock_bh(&srq->rq.consumer_lock); pr_warn("%s: invalid num_sge in SRQ entry\n", __func__); return RESPST_ERR_MALFORMED_WQE; } |