diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2017-09-08 15:37:45 +0100 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2017-10-09 09:03:16 -0400 |
| commit | 4831ca9e4a8e48cb27e0a792f73250390827a228 (patch) | |
| tree | daf13538790e8083570c7b1b04a115e785e27b45 /drivers/infiniband/sw | |
| parent | IB/hfi1: Do not warn on lid conversions for OPA (diff) | |
| download | linux-dev-4831ca9e4a8e48cb27e0a792f73250390827a228.tar.xz linux-dev-4831ca9e4a8e48cb27e0a792f73250390827a228.zip | |
IB/rxe: check for allocation failure on elem
The allocation for elem may fail (especially because we're using
GFP_ATOMIC) so best to check for a null return. This fixes a potential
null pointer dereference when assigning elem->pool.
Detected by CoverityScan CID#1357507 ("Dereference null return value")
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/sw')
| -rw-r--r-- | drivers/infiniband/sw/rxe/rxe_pool.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_pool.c b/drivers/infiniband/sw/rxe/rxe_pool.c index c1b5f38f31a5..3b4916680018 100644 --- a/drivers/infiniband/sw/rxe/rxe_pool.c +++ b/drivers/infiniband/sw/rxe/rxe_pool.c @@ -404,6 +404,8 @@ void *rxe_alloc(struct rxe_pool *pool) elem = kmem_cache_zalloc(pool_cache(pool), (pool->flags & RXE_POOL_ATOMIC) ? GFP_ATOMIC : GFP_KERNEL); + if (!elem) + return NULL; elem->pool = pool; kref_init(&elem->ref_cnt); |